Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Add backup/restore privilege to admin group #35515

Merged
merged 1 commit into from
Aug 16, 2024
Merged

enhance: Add backup/restore privilege to admin group #35515

merged 1 commit into from
Aug 16, 2024

Conversation

weiliu1031
Copy link
Contributor

issue: #35443

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 16, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Aug 16, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.83%. Comparing base (f4a91e1) to head (57ff3f1).
Report is 8 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35515      +/-   ##
==========================================
+ Coverage   81.48%   84.83%   +3.34%     
==========================================
  Files        1221      948     -273     
  Lines      145051   120555   -24496     
==========================================
- Hits       118198   102273   -15925     
+ Misses      22391    13807    -8584     
- Partials     4462     4475      +13
Files Coverage Δ
pkg/util/constant.go 100.00% <ø> (ø)

... and 312 files with indirect coverage changes

@SimFG
Copy link
Contributor

SimFG commented Aug 16, 2024

/lgtm

congqixia
congqixia approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ead3732 into milvus-io:master Aug 16, 2024
15 checks passed
@weiliu1031 weiliu1031 mentioned this pull request Aug 19, 2024
Merged
weiliu1031 added a commit to weiliu1031/milvus that referenced this pull request Aug 19, 2024
@weiliu1031
enhance: Add backup/restore privilege to admin group (milvus-io#35515)
09abd89 
issue: milvus-io#35443

Signed-off-by: Wei Liu <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Aug 19, 2024
@weiliu1031
enhance: Enable ReadOnly/ReadWrite/Admin Privilege Group to simplify …
14ec3dc 
…RBAC grant progress (#35472) (#35543)

issue: #35471
pr: #35472 #35515

---------

---------

Signed-off-by: Wei Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@SimFG SimFG

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weiliu1031 @SimFG @sre-ci-robot @congqixia